forks/microblog.pub
1
0
Fork 1
mirror of https://git.sr.ht/~tsileo/microblog.pub synced 2024-12-22 05:04:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use <details> element for sensitive text

Browse source 
The sensitive text feature was implemented with <label> and hidden
checkbox <input> elements. There were two issues with this
implementation:
1. The user couldn't navigate to the "show/hide more" button using
   keyboard.
2. The label indicates two actions at the same time ("show/hide more"),
   making it unclear what the function of the checkbox was and what the
   current show/collapse state was.

As it is generally preferrable to use built-in HTML elements for the
best semantic, this commit moves to use the <details> and <summary>
elements for the sensitive text feature. The browser will open/collapse
the content in <details> automatically when the user clicks on the
<summary>, and keyboard navigation support is built-in.

This commit also changes the button to display "show more" or "show
less" depending on the state for visual clarity. This button is hidden
from the accessibility tree using `aria-label="false"`, as the <details>
element already exposes its state to the tree and we want to avoid
duplicated information.

A few caveats:
* The "show/hide sensitive content" button for sensitive attachments
  hasn't been changed yet as I'd like to get more feedback about the new
  implementation.
* As the summary/content warning text itself is also part of the
  <summary> tag, the user can now also click on them to toggle the
  visibility of the sensitive text. This may not be desirable as the
  current interface does not make it clear that this could happen; the
  user may try to select some text from the summary and be surprised
  by the sensitive text being expanded. One way to improve this would
  be to add an event listener to the summary text and call
  `preventDefault`, but this would introduce JavaScript code.
This commit is contained in:
Jane 2022-11-25 00:56:57 -06:00 committed by Thomas Sileo
parent 46a592b11e
commit 68884d9afa
2 changed files with 18 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/scss/main.scss
View file

@ -51,17 +51,20 @@ $code-highlight-background: #f0f0f0;
.p-summary { .p-summary {
display: inline-block; display: inline-block;
} }
label { .show-more-btn {
margin-left: 5px; margin-left: 5px;
} }
.show-more-state { summary {
display: none; display: inline-block;
} }
.show-more-state ~ .obj-content { summary::-webkit-details-marker {
margin-top: 0; display: none
} }
.show-more-state:checked ~ .obj-content { &:not([open]) .show-more-btn::after {
display: none; content: 'show more';
}
&[open] .show-more-btn::after {
content: 'show less';
} }
} }
.sensitive-attachment { .sensitive-attachment {

15
app/templates/utils.html
View file

@ -549,12 +549,13 @@
{% endif %} {% endif %}
{% if object.summary %} {% if object.summary %}
<div class="show-more-wrapper"> <details class="show-more-wrapper">
<div class="p-summary"> <summary>
<p>{{ object.summary | clean_html(object) | safe }}</p> <div class="p-summary">
</div> <p>{{ object.summary | clean_html(object) | safe }}</p>
<label for="show-more-{{ object.permalink_id }}" class="show-more-btn">show/hide more</label> </div>
<input class="show-more-state" type="checkbox" aria-hidden="true" id="show-more-{{ object.permalink_id }}" checked> <span class="show-more-btn" aria-hidden="true"></span>
</summary>
{% endif %} {% endif %}
<div class="obj-content"> <div class="obj-content">
<div class="e-content"> <div class="e-content">
@ -615,7 +616,7 @@
</div> </div>
{% if object.summary %} {% if object.summary %}
</div> </details>
{% endif %} {% endif %}
<div class="activity-attachment"> <div class="activity-attachment">