From 4b051ef24348c178f482937f361d0e718140d019 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Mon, 21 Mar 2022 16:17:54 -0700 Subject: [PATCH] Do not set conversation expire timer on incoming story msgs Co-authored-by: Josh Perez <60019601+josh-signal@users.noreply.github.com> --- ts/models/messages.ts | 2 +- ts/textsecure/MessageReceiver.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ts/models/messages.ts b/ts/models/messages.ts index a1ccee2e2..53ca4a1b9 100644 --- a/ts/models/messages.ts +++ b/ts/models/messages.ts @@ -2431,7 +2431,7 @@ export class MessageModel extends window.Backbone.Model { message.set({ expireTimer: dataMessage.expireTimer }); } - if (!hasGroupV2Prop) { + if (!hasGroupV2Prop && !isStory(message.attributes)) { if (isExpirationTimerUpdate(message.attributes)) { message.set({ expirationTimerUpdate: { diff --git a/ts/textsecure/MessageReceiver.ts b/ts/textsecure/MessageReceiver.ts index 79cb0b81d..e1dfa880d 100644 --- a/ts/textsecure/MessageReceiver.ts +++ b/ts/textsecure/MessageReceiver.ts @@ -1811,7 +1811,10 @@ export default class MessageReceiver return; } - const expireTimer = envelope.timestamp + durations.DAY - Date.now(); + const expireTimer = Math.min( + (envelope.serverTimestamp + durations.DAY - Date.now()) / 1000, + durations.DAY / 1000 + ); if (expireTimer <= 0) { log.info(