jonny
/
Signal-Desktop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant listenTo calls in ConversationModel#fetchContacts

This commit is contained in:
Evan Hahn 2021-03-29 15:43:31 -05:00 committed by GitHub
parent 7a3130a795
commit 902e48e308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ts/models/conversations.ts
View File

@ -230,6 +230,12 @@ export class ConversationModel extends window.Backbone.Model<
this.debouncedUpdateLastMessage,
this
);
if (!this.isPrivate()) {
this.contactCollection.on(
'change:verified',
this.onMemberVerifiedChange.bind(this)
);
}
this.messageCollection = new window.Whisper.MessageCollection([], {
conversation: this,
@ -1986,8 +1992,6 @@ export class ConversationModel extends window.Backbone.Model<
}
})
);
this.onMemberVerifiedChange();
}
setVerifiedDefault(options?: VerificationOptions): Promise<unknown> {
@ -4750,14 +4754,7 @@ export class ConversationModel extends window.Backbone.Model<
}
fetchContacts(): void {
if (this.isPrivate()) {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
this.contactCollection!.reset([this]);
}
const members = this.getMembers();
window._.forEach(members, member => {
this.listenTo(member, 'change:verified', this.onMemberVerifiedChange);
});
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
this.contactCollection!.reset(members);