ESLint: allow `for..of`

.eslintrc.js

@@ -95,11 +95,6 @@ const rules = {
       message:
         'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
     },
-    {
-      selector: 'ForOfStatement',
-      message:
-        'iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.',
-    },
     {
       selector: 'LabeledStatement',
       message:

js/modules/types/message.js

@@ -1,4 +1,4 @@
-// Copyright 2018-2020 Signal Messenger, LLC
+// Copyright 2018-2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
 const { isFunction, isObject, isString, omit } = require('lodash');
@@ -392,7 +392,6 @@ exports.upgradeSchema = async (
   }
 
   let message = rawMessage;
-  // eslint-disable-next-line no-restricted-syntax
   for (let index = 0, max = VERSIONS.length; index < max; index += 1) {
     if (maxVersion < index) {
       break;

ts/SignalProtocolStore.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable class-methods-use-this */
-/* eslint-disable no-restricted-syntax */
 
 import PQueue from 'p-queue';
 import { isNumber } from 'lodash';

ts/challenge.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 // `ChallengeHandler` is responsible for:
 // 1. tracking the messages that failed to send with 428 error and could be

ts/components/DisappearingTimeDialog.tsx

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import React, { useState } from 'react';
 

ts/jobs/JobQueue.ts

@@ -125,9 +125,6 @@ export abstract class JobQueue<T> {
     log.info(`${this.logPrefix} starting to stream jobs`);
 
     const stream = this.store.stream(this.queueType);
-    // We want to enqueue the jobs in sequence, not in parallel. `for await ... of` is a
-    //   good way to do that.
-    // eslint-disable-next-line no-restricted-syntax
     for await (const storedJob of stream) {
       this.enqueueStoredJob(storedJob);
     }

ts/linkPreviews/linkPreviewFetch.ts

@@ -293,8 +293,6 @@ const getHtmlDocument = async (
   let bytesLoadedSoFar = 0;
 
   try {
-    // `for ... of` is much cleaner here, so we allow it.
-    /* eslint-disable no-restricted-syntax */
     for await (let chunk of body) {
       if (abortSignal.aborted) {
         break;
@@ -322,7 +320,6 @@ const getHtmlDocument = async (
         break;
       }
     }
-    /* eslint-enable no-restricted-syntax */
   } catch (err) {
     window.log.warn(
       'getHtmlDocument: error when reading body; continuing with what we got'

ts/main/NativeThemeNotifier.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import { ipcMain as ipc, nativeTheme, BrowserWindow } from 'electron';
 

ts/main/challengeMain.ts

@@ -1,6 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax, no-console */
+/* eslint-disable no-console */
 
 import { ipcMain as ipc, IpcMainEvent } from 'electron';
 

ts/messages/migrateLegacySendAttributes.ts

@@ -45,7 +45,6 @@ export function migrateLegacySendAttributes(
     return undefined;
   }
 
-  /* eslint-disable no-restricted-syntax */
   const pendingSendState: SendState = {
     status: SendStatus.Pending,
     updatedAt: message.sent_at,
@@ -129,7 +128,6 @@ export function migrateLegacySendAttributes(
   }
 
   return sendStateByConversationId;
-  /* eslint-enable no-restricted-syntax */
 }
 
 function getConversationIdsFromErrors(

ts/models/messages.ts

@@ -1237,7 +1237,6 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
 
     const recipients: Array<string> = [];
     const newSendStateByConversationId = { ...oldSendStateByConversationId };
-    // eslint-disable-next-line no-restricted-syntax
     for (const [conversationId, sendState] of Object.entries(
       oldSendStateByConversationId
     )) {

ts/routineProfileRefresh.ts

@@ -1,9 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-// We use `for ... of` to deal with iterables in several places in this file.
-/* eslint-disable no-restricted-syntax */
-
 import { isNil, sortBy } from 'lodash';
 import PQueue from 'p-queue';
 

ts/sql/Client.ts

@@ -7,7 +7,6 @@
 /* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/ban-types */
-/* eslint-disable no-restricted-syntax */
 import { ipcRenderer } from 'electron';
 
 import {

ts/sql/Server.ts

@@ -4,7 +4,6 @@
 /* eslint-disable no-nested-ternary */
 /* eslint-disable camelcase */
 /* eslint-disable @typescript-eslint/explicit-module-boundary-types */
-/* eslint-disable no-restricted-syntax */
 /* eslint-disable no-console */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 

ts/sql/cleanDataForIpc.ts

@@ -129,9 +129,6 @@ function cleanDataInner(
         const result: CleanedArray = [];
         let index = 0;
         pathsChanged.push(path);
-        // `for ... of` is the cleanest way to go through "generic" iterables without
-        //   a helper library.
-        // eslint-disable-next-line no-restricted-syntax
         for (const value of dataAsRecord) {
           result.push(
             cleanDataInner(

ts/test-both/AsyncQueue_test.ts

@@ -1,8 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-/* eslint-disable no-restricted-syntax */
-
 import { assert } from 'chai';
 
 import { AsyncQueue } from '../util/AsyncQueue';

ts/test-both/challenge_test.ts

@@ -1,6 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-await-in-loop, no-restricted-syntax */
+/* eslint-disable no-await-in-loop */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
 import { assert } from 'chai';

ts/test-both/processDataMessage_test.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import { assert } from 'chai';
 import Long from 'long';

ts/test-both/util/asyncIterables_test.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable no-await-in-loop */
-/* eslint-disable no-restricted-syntax */
 
 import { assert } from 'chai';
 

ts/test-both/util/explodePromise_test.ts

@@ -1,8 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-/* eslint-disable no-restricted-syntax */
-
 import { assert } from 'chai';
 
 import { explodePromise } from '../../util/explodePromise';

ts/test-node/jobs/JobQueueDatabaseStore_test.ts

@@ -1,8 +1,6 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-/* eslint-disable no-restricted-syntax */
-
 import { assert } from 'chai';
 import * as sinon from 'sinon';
 import { noop } from 'lodash';

ts/test-node/jobs/TestJobQueueStore.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable max-classes-per-file */
-/* eslint-disable no-restricted-syntax */
 /* eslint-disable no-await-in-loop */
 
 import EventEmitter, { once } from 'events';

ts/test-node/logging/uploadDebugLogs_test.ts

@@ -95,9 +95,6 @@ describe('uploadDebugLogs', () => {
       { fields: { key: '123' }, url: 'not a valid URL' },
     ];
 
-    // We want to make sure these run serially, so we can't use `Promise.all`. They're
-    //   async, so we can't use `forEach`. `for ... of` is a reasonable option here.
-    // eslint-disable-next-line no-restricted-syntax
     for (const body of bodies) {
       this.fakeGet.resolves({ body });
 

ts/textsecure/MessageReceiver.ts

@@ -4,7 +4,6 @@
 /* eslint-disable no-bitwise */
 /* eslint-disable class-methods-use-this */
 /* eslint-disable camelcase */
-/* eslint-disable no-restricted-syntax */
 
 import { isNumber, map } from 'lodash';
 import PQueue from 'p-queue';

ts/textsecure/OutgoingMessage.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable guard-for-in */
-/* eslint-disable no-restricted-syntax */
 /* eslint-disable class-methods-use-this */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable more/no-then */

ts/textsecure/SocketManager.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import URL from 'url';
 import ProxyAgent from 'proxy-agent';

ts/textsecure/Storage.ts

@@ -1,6 +1,5 @@
 // Copyright 2020-2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import {
   StorageAccessType as Access,

ts/textsecure/WebsocketResources.ts

@@ -1,7 +1,7 @@
-// Copyright 2020 Signal Messenger, LLC
+// Copyright 2020-2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
-/* eslint-disable max-classes-per-file, no-restricted-syntax */
+/* eslint-disable max-classes-per-file */
 /*
  * WebSocket-Resources
  *

ts/types/Stickers.ts

@@ -1,6 +1,5 @@
 // Copyright 2019-2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import { isNumber, pick, reject, groupBy, values } from 'lodash';
 import pMap from 'p-map';

ts/util/StartupQueue.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import * as Errors from '../types/errors';
 

ts/util/asyncIterables.ts

@@ -3,7 +3,6 @@
 
 /* eslint-disable max-classes-per-file */
 /* eslint-disable no-await-in-loop */
-/* eslint-disable no-restricted-syntax */
 
 export type MaybeAsyncIterable<T> = Iterable<T> | AsyncIterable<T>;
 

ts/util/awaitObject.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 export async function awaitObject<Result extends { [key: string]: unknown }>(
   settings: {

ts/util/combineNames.ts

@@ -1,4 +1,4 @@
-// Copyright 2020 Signal Messenger, LLC
+// Copyright 2020-2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable camelcase */
@@ -56,7 +56,6 @@ export function combineNames(
 }
 
 function isAllCKJV(name: string): boolean {
-  // eslint-disable-next-line no-restricted-syntax
   for (const codePoint of name) {
     if (!isCKJV(codePoint)) {
       return false;

ts/util/dropNull.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 export type NullToUndefined<T> = Extract<T, null> extends never
   ? T

ts/util/emoji.ts

@@ -1,6 +1,5 @@
 // Copyright 2021 Signal Messenger, LLC
 // SPDX-License-Identifier: AGPL-3.0-only
-/* eslint-disable no-restricted-syntax */
 
 import emojiRegex from 'emoji-regex/es2015/RGI_Emoji';
 

ts/util/iterables.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 /* eslint-disable max-classes-per-file */
-/* eslint-disable no-restricted-syntax */
 
 import { getOwn } from './getOwn';