Remove floating date header remote config flags

This commit is contained in:
Evan Hahn 2022-01-27 15:50:01 -06:00 committed by GitHub
parent 53a27d022f
commit babd61377b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 1 additions and 29 deletions

View File

@ -10,8 +10,6 @@ export type ConfigKeyType =
| 'desktop.announcementGroup'
| 'desktop.clientExpiration'
| 'desktop.disableGV1'
| 'desktop.floatingDateHeaders.beta'
| 'desktop.floatingDateHeaders.production'
| 'desktop.groupCallOutboundRing'
| 'desktop.groupCalling'
| 'desktop.gv2'

View File

@ -120,8 +120,6 @@ type PropsHousekeepingType = {
i18n: LocalizerType;
theme: ThemeType;
areFloatingDateHeadersEnabled?: boolean;
renderItem: (props: {
actionProps: PropsActionsType;
containerElementRef: RefObject<HTMLElement>;
@ -1251,7 +1249,6 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
public override render(): JSX.Element | null {
const {
acknowledgeGroupMemberNameCollisions,
areFloatingDateHeadersEnabled = true,
areWeAdmin,
clearInvitedUuidsForNewlyCreatedGroup,
closeContactSpoofingReview,
@ -1293,7 +1290,7 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
let floatingHeader: ReactNode;
const oldestPartiallyVisibleRow = visibleRows?.oldestPartiallyVisible;
if (areFloatingDateHeadersEnabled && oldestPartiallyVisibleRow) {
if (oldestPartiallyVisibleRow) {
floatingHeader = (
<TimelineFloatingHeader
i18n={i18n}

View File

@ -15,7 +15,6 @@ import type {
} from '../../types/Colors';
import { DEFAULT_CONVERSATION_COLOR } from '../../types/Colors';
import { getPreferredReactionEmoji as getPreferredReactionEmojiFromStoredValue } from '../../reactions/preferredReactionEmoji';
import { getIsAlpha, getIsBeta } from './user';
const DEFAULT_PREFERRED_LEFT_PANE_WIDTH = 320;
@ -59,25 +58,6 @@ export const getUsernamesEnabled = createSelector(
isRemoteConfigFlagEnabled(remoteConfig, 'desktop.usernames')
);
export const getAreFloatingDateHeadersEnabled = createSelector(
getRemoteConfig,
getIsAlpha,
getIsBeta,
(remoteConfig: ConfigMapType, isAlpha, isBeta): boolean => {
if (
isAlpha ||
isRemoteConfigFlagEnabled(remoteConfig, 'desktop.internalUser')
) {
return true;
}
const remoteConfigKey: ConfigKeyType = isBeta
? 'desktop.floatingDateHeaders.beta'
: 'desktop.floatingDateHeaders.production';
return isRemoteConfigFlagEnabled(remoteConfig, remoteConfigKey);
}
);
export const getDefaultConversationColor = createSelector(
getItems,
(

View File

@ -18,7 +18,6 @@ import { Timeline } from '../../components/conversation/Timeline';
import type { StateType } from '../reducer';
import type { ConversationType } from '../ducks/conversations';
import { getAreFloatingDateHeadersEnabled } from '../selectors/items';
import { getIntl, getTheme } from '../selectors/user';
import {
getConversationByUuidSelector,
@ -322,8 +321,6 @@ const mapStateToProps = (state: StateType, props: ExternalProps) => {
warning: getWarning(conversation, state),
contactSpoofingReview: getContactSpoofingReview(id, state),
areFloatingDateHeadersEnabled: getAreFloatingDateHeadersEnabled(state),
getTimestampForMessage,
getPreferredBadge: getPreferredBadgeSelector(state),
i18n: getIntl(state),