Ensure that context is always provided for error logs

This commit is contained in:
Scott Nonnenberg 2021-05-19 15:00:57 -07:00
parent 7418a5c663
commit be087c3498
5 changed files with 18 additions and 5 deletions

View File

@ -1527,7 +1527,10 @@ ipc.handle('show-calling-permissions-popup', async (event, forCamera) => {
try {
await showPermissionsPopupWindow(true, forCamera);
} catch (error) {
console.error(error);
console.error(
'show-calling-permissions-popup error:',
error && error.stack ? error.stack : error
);
}
});
ipc.on('close-permissions-popup', () => {

View File

@ -60,7 +60,9 @@ export const CallingNotification: React.FC<PropsType> = React.memo(props => {
callType = 'video';
break;
default:
window.log.error(missingCaseError(props));
window.log.error(
`CallingNotification missing case: ${missingCaseError(props)}`
);
return null;
}

View File

@ -865,7 +865,11 @@ export class MessageModel extends window.Backbone.Model<MessageAttributesType> {
};
}
default:
window.log.error(missingCaseError(callHistoryDetails));
window.log.error(
`getPropsForCallHistory: missing case ${missingCaseError(
callHistoryDetails
)}`
);
return undefined;
}
}

View File

@ -16,6 +16,6 @@ export function assert(condition: unknown, message: string): asserts condition {
}
throw err;
}
log.error(err);
log.error('assert failure:', err && err.stack ? err.stack : err);
}
}

View File

@ -102,7 +102,11 @@ export function getCallingNotificationText(
case CallMode.Group:
return getGroupCallNotificationText(notification, i18n);
default:
window.log.error(missingCaseError(notification));
window.log.error(
`getCallingNotificationText: missing case ${missingCaseError(
notification
)}`
);
return '';
}
}