From bffbc1e5cf0e91c7f598c7dbc42ad605e5b8b9a9 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Mon, 13 Jul 2020 16:47:27 -0700 Subject: [PATCH] Readme update; fix package.json scripts for Windows --- CONTRIBUTING.md | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 69bbdac0a..0315cedd6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,7 +36,7 @@ Then you need `git`, if you don't have that yet: https://git-scm.com/ https://www.microsoft.com/en-us/download/details.aspx?id=40773 - Install Windows SDK version 8.1: https://developer.microsoft.com/en-us/windows/downloads/sdk-archive 1. Install _Windows Build Tools_: Open the [Command Prompt (`cmd.exe`) as Administrator]() - and run: `npm install --global --production --add-python-to-path windows-build-tools` + and run: `npm install --vs2015 --global --production --add-python-to-path windows-build-tools` ### Linux diff --git a/package.json b/package.json index 003a88ed5..d86a4e06e 100644 --- a/package.json +++ b/package.json @@ -43,9 +43,9 @@ "ready": "yarn clean-transpile && yarn grunt && yarn lint && yarn test-node && yarn test-electron && yarn lint-deps", "dev": "run-p --print-label dev:*", "dev:grunt": "yarn grunt dev", - "dev:webpack": "NODE_ENV=development webpack-dev-server --hot", + "dev:webpack": "cross-env NODE_ENV=development webpack-dev-server --hot", "dev:typed-scss": "yarn build:typed-scss -w", - "dev:storybook": "SIGNAL_ENV=storybook start-storybook -p 6006 -s ./", + "dev:storybook": "cross-env SIGNAL_ENV=storybook start-storybook -p 6006 -s ./", "build": "run-s --print-label build:grunt build:typed-scss build:webpack build:release build:zip", "build:dev": "run-s --print-label build:grunt build:typed-scss build:webpack", "build:grunt": "yarn grunt",