diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6dc3fd66d..1f274d634 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,7 +14,7 @@ Remember, you can preview this before saving it. ### Contributor checklist: -- [ ] My contribution is **not** related to translations. _Please submit translation changes via our [Signal Desktop Transifex project](https://www.transifex.com/signalapp/signal-desktop/)._ +- [ ] My contribution is **not** related to translations. - [ ] My commits are in nice logical chunks with [good commit messages](http://chris.beams.io/posts/git-commit/) - [ ] My changes are [rebased](https://medium.com/free-code-camp/git-rebase-and-the-golden-rule-explained-70715eccc372) on the latest [`main`](https://github.com/signalapp/Signal-Desktop/tree/main) branch - [ ] A `yarn ready` run passes successfully ([more about tests here](https://github.com/signalapp/Signal-Desktop/blob/master/CONTRIBUTING.md#tests)) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 170caed33..7784d6bbe 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,4 +1,4 @@ - + # Contributor Guidelines @@ -191,13 +191,11 @@ So you wanna make a pull request? Please observe the following guidelines. - First, make sure that your `yarn ready` run passes - it's very similar to what our Continuous Integration servers do to test the app. -- Please do not submit pull requests for translation fixes. Anyone can update - the translations in [Transifex](https://www.transifex.com/projects/p/signal-desktop). +- Please do not submit pull requests for translation fixes. - Never use plain strings right in the source code - pull them from `messages.json`! You **only** need to modify the default locale [`_locales/en/messages.json`](_locales/en/messages.json). Other locales are generated - automatically based on that file and then periodically uploaded to Transifex for - translation. + automatically based on that file and then periodically translated. - [Rebase](https://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/) your changes on the latest `main` branch, resolving any conflicts. This ensures that your changes will merge cleanly when you open your PR. diff --git a/README.md b/README.md index 3f387db2c..34ad86518 100644 --- a/README.md +++ b/README.md @@ -20,12 +20,6 @@ Please search for any [existing issues](https://github.com/signalapp/Signal-Desk Please use our community forum: https://community.signalusers.org/ -## Contributing Translations - -Interested in helping to translate Signal? Contribute here: - -https://www.transifex.com/projects/p/signal-desktop - ## Contributing Code Please see [CONTRIBUTING.md](https://github.com/signalapp/Signal-Desktop/blob/main/CONTRIBUTING.md)