v5.63.0-beta.1

This reverts commit a2eac80034.

.eslintignore

@@ -1,4 +1,3 @@
-build/**
 components/**
 coverage/**
 dist/**
@@ -15,6 +14,7 @@ libtextsecure/components.js
 libtextsecure/test/test.js
 test/test.js
 sticker-creator/dist/**
+ts/protobuf/compiled.d.ts
 
 # Third-party files
 js/Mp3LameEncoder.min.js
@@ -25,7 +25,6 @@ app/**/*.js
 ts/**/*.js
 sticker-creator/**/*.js
 
-**/*.d.ts
 .eslintrc.js
 webpack.config.ts
 preload.bundle.*

.eslintrc.js

@@ -15,6 +15,14 @@ const rules = {
     },
   ],
 
+  // No omitting braces, keep on the same line
+  'brace-style': ['error', '1tbs', { allowSingleLine: false }],
+  curly: ['error', 'all'],
+
+  // Always use === and !== except when directly comparing to null
+  // (which only will equal null or undefined)
+  eqeqeq: ['error', 'always', { null: 'never' }],
+
   // prevents us from accidentally checking in exclusive tests (`.only`):
   'mocha/no-exclusive-tests': 'error',
 
@@ -28,6 +36,9 @@ const rules = {
   // useful for unused or internal fields
   'no-underscore-dangle': 'off',
 
+  // Temp: We have because TypeScript's `allowUnreachableCode` option is on.
+  'no-unreachable': 'error',
+
   // though we have a logger, we still remap console to log to disk
   'no-console': 'error',
 
@@ -109,12 +120,19 @@ const rules = {
         '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
     },
   ],
-  curly: 'error',
 };
 
 const typescriptRules = {
   ...rules,
 
+  // Override brace style to enable typescript-specific syntax
+  'brace-style': 'off',
+  '@typescript-eslint/brace-style': [
+    'error',
+    '1tbs',
+    { allowSingleLine: false },
+  ],
+
   '@typescript-eslint/array-type': ['error', { default: 'generic' }],
 
   'no-restricted-imports': 'off',
@@ -173,6 +191,7 @@ module.exports = {
         'app/**/*.ts',
         'sticker-creator/**/*.ts',
         'sticker-creator/**/*.tsx',
+        'build/intl-linter/**/*.ts',
       ],
       parser: '@typescript-eslint/parser',
       parserOptions: {
@@ -193,7 +212,12 @@ module.exports = {
       rules: typescriptRules,
     },
     {
-      files: ['**/*.stories.tsx', 'ts/build/**', 'ts/test-*/**'],
+      files: [
+        '**/*.stories.tsx',
+        'ts/build/**',
+        'ts/test-*/**',
+        'build/intl-linter/**/*.ts',
+      ],
       rules: {
         ...typescriptRules,
         'import/no-extraneous-dependencies': 'off',

.github/workflows/ci.yml

@@ -42,7 +42,7 @@ jobs:
 
   macos:
     needs: lint
-    runs-on: macos-11
+    runs-on: macos-latest
     if: github.ref == 'refs/heads/development' || github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main'
     timeout-minutes: 30
 
@@ -66,14 +66,14 @@ jobs:
 
     - run: yarn generate
     - run: yarn prepare-beta-build
+    - run: yarn test-node
+    - run: yarn test-electron
+      timeout-minutes: 5
     - run: yarn build
       env:
         DISABLE_INSPECT_FUSE: on
     - name: Rebuild native modules for x64
       run: yarn electron:install-app-deps
-    - run: yarn test-node
-    - run: yarn test-electron
-      timeout-minutes: 5
     - run: yarn test-release
       env:
         NODE_ENV: production

.github/workflows/danger.yml

@@ -0,0 +1,32 @@
+# Copyright 2020-2022 Signal Messenger, LLC
+# SPDX-License-Identifier: AGPL-3.0-only
+
+name: CI
+on:
+  pull_request:
+
+jobs:
+  danger:
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0 # fetch all history
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '16.15.0'
+      - run: npm install -g yarn@1.22.10
+      - name: Cache danger node_modules
+        id: cache-desktop-modules
+        uses: actions/cache@v3
+        with:
+          path: danger/node_modules
+          key: danger-${{ runner.os }}-${{ hashFiles('danger/package.json', 'danger/yarn.lock') }}
+      - name: Install danger node_modules
+        if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
+        run: cd danger && yarn install --frozen-lockfile
+      - name: Run DangerJS
+        run: yarn danger:ci
+        env:
+          DANGER_GITHUB_API_TOKEN: ${{ secrets.AUTOMATED_GITHUB_PAT }}

.gitignore

@@ -1,4 +1,5 @@
 node_modules
+node_modules_bkp
 .sass-cache
 coverage/*
 build/curve25519_compiled.js
@@ -16,6 +17,7 @@ release/
 /start.sh
 .eslintcache
 tsconfig.tsbuildinfo
+.smartling-source.sh
 
 # generated files
 js/components.js

.prettierignore

@@ -35,12 +35,6 @@ js/WebAudioRecorderMp3.js
 # Github workflows
 .github/**
 
-# Managed by Transifex:
-# Note: the negate pattern only works because it's targeting the same depth as the
-#   glob on the previous line.
-_locales/**/*.json
-!_locales/en/messages.json
-
 # Managed by package manager (`bower` and `yarn`/`npm`):
 /bower.json
 /package.json

.smartling-source-example.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+# Copyright 2022 Signal Messenger, LLC
+# SPDX-License-Identifier: AGPL-3.0-only
+
+# run this before yarn get-strings/push-strings:
+#   source .smartling-source.sh
+
+export SMARTLING_USER="your token 'user identifier' here"
+export SMARTLING_SECRET="your token secret here"

.smartling.yml

@@ -0,0 +1,7 @@
+# Copyright 2022 Signal Messenger, LLC
+# SPDX-License-Identifier: AGPL-3.0-only
+
+# https://github.com/Smartling/smartling-cli/wiki/examples.md
+
+account_id: '92ff14ad'
+project_id: 'ef62d1ebb'

.storybook/preview.tsx

@@ -70,7 +70,7 @@ const withModeAndThemeProvider = (Story, context) => {
 };
 
 const withI18n = (Story, context) => (
-  <I18n messages={messages}>
+  <I18n messages={messages} locale="en">
     <Story {...context} />
   </I18n>
 );

.tx/config

@@ -1,9 +0,0 @@
-[main]
-host = https://www.transifex.com
-
-[o:signalapp:p:signal-desktop:r:messagesjson-electron]
-file_filter = _locales/<lang>/messages.json
-source_file = _locales/en/messages.json
-source_lang = en
-type        = CHROME
-

ACKNOWLEDGMENTS.md

@@ -5,6 +5,10 @@
 
 Signal Desktop makes use of the following open source projects.
 
+## @formatjs/fast-memoize
+
+    License: MIT
+
 ## @indutny/frameless-titlebar
 
     MIT License
@@ -2648,10 +2652,6 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
-## pino-multi-stream
-
-    License: MIT
-
 ## protobufjs
 
     This license applies to all parts of protobuf.js except those files
@@ -2863,6 +2863,10 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
+## react-intl
+
+    License: BSD-3-Clause
+
 ## react-measure
 
     The MIT License (MIT)
@@ -3178,30 +3182,6 @@ Signal Desktop makes use of the following open source projects.
     ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
     IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
-## rotating-file-stream
-
-    The MIT License (MIT)
-
-    Copyright (c) 2015-2020 Daniele Ricci
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to deal
-    in the Software without restriction, including without limitation the rights
-    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-    copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in all
-    copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-    SOFTWARE.
-
 ## sanitize.css
 
     License: CC0-1.0

CONTRIBUTING.md

@@ -272,15 +272,3 @@ yarn build
 ```
 
 Then, run the tests using `yarn test-release`.
-
-## Translations
-
-To pull the latest translations, follow these steps:
-
-1.  Download Transifex client:
-    https://docs.transifex.com/client/installing-the-client
-2.  Create Transifex account: https://transifex.com
-3.  Generate API token: https://www.transifex.com/user/settings/api/
-4.  Create `~/.transifexrc` configuration:
-    https://docs.transifex.com/client/client-configuration#-transifexrc
-5.  Run `yarn get-strings`.