From 01dbda42cab9b62b9f405ec05a9034016d3c12ed Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Fri, 8 May 2020 07:20:12 -0700 Subject: [PATCH] Don't "break" the variants by breaking early Hope you enjoyed the pun, as this is an unfortunate bug to have slipped into production. While previously we breaked after finding the selected items prior to I098e6921e8f7ef65dacacf09b9c25f70c945e58e we shouldn't do that any more as we're using the same loop to iterate through and generate our items! Bug: T251521 Change-Id: I92c28e8fba684d7977dfd207ff939ac07a7a07af --- includes/VectorTemplate.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/VectorTemplate.php b/includes/VectorTemplate.php index 24d4300a..c9fe266d 100644 --- a/includes/VectorTemplate.php +++ b/includes/VectorTemplate.php @@ -477,7 +477,6 @@ class VectorTemplate extends BaseTemplate { if ( $setLabelToSelected ) { if ( isset( $item['class'] ) && stripos( $item['class'], 'selected' ) !== false ) { $props['label'] = $item['text']; - break; } } }