From 1297733a65e8129a12ad79dfa718455e16d0dfa6 Mon Sep 17 00:00:00 2001 From: Clare Ming Date: Thu, 21 Jul 2022 16:21:53 -0600 Subject: [PATCH] Add text to TOC collapsible button label for accessibility. - Provide message translations. - Include other TOC message that was missing. Bug: T310810 Change-Id: Ibd612b48ea3ef3f9f31f4bb5791c0cb82e447ece --- i18n/en.json | 1 + i18n/qqq.json | 1 + includes/templates/ContentHeader.mustache | 1 + skin.json | 2 ++ 4 files changed, 5 insertions(+) diff --git a/i18n/en.json b/i18n/en.json index b20d1597..fc45d73f 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -44,6 +44,7 @@ "vector-anon-user-menu-pages-label": "Learn more about editing", "vector-main-menu-tooltip": "Main menu", "vector-toc-menu-tooltip": "Table of Contents", + "vector-toc-collapsible-button-label": "Toggle the table of contents", "vector-article-tools-nav-label": "Tools", "vector-site-nav-label": "Site", "vector-2022-prefs-talkpage": "[[mw:Talk:Reading/Web/Desktop_Improvements|Discussion]]", diff --git a/i18n/qqq.json b/i18n/qqq.json index 3f2de129..1aec6e9c 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -59,6 +59,7 @@ "vector-anon-user-menu-pages-label": "Accessible version of 'vector-anon-user-menu-pages' link text, prompts user to learn more about editing", "vector-main-menu-tooltip": "Used as title attribute for main menu icon on hover.", "vector-toc-menu-tooltip": "Used as title attribute for table of contents icon on hover.", + "vector-toc-collapsible-button-label": "Used as the label for the table of contents collapsible toggle button", "vector-article-tools-nav-label": "Accessible label for the article tools nav landmark", "vector-site-nav-label": "Accessible label for site (main menu) nav landmark", "vector-2022-prefs-talkpage": "Link to the desktop improvements project talk page which is shown before the preview link in skin preferences. See T307113 for more information.", diff --git a/includes/templates/ContentHeader.mustache b/includes/templates/ContentHeader.mustache index 80004824..44df8c34 100644 --- a/includes/templates/ContentHeader.mustache +++ b/includes/templates/ContentHeader.mustache @@ -23,6 +23,7 @@ data-event-name="vector.toc-toggle-list" tabindex="0" title="{{msg-vector-toc-menu-tooltip}}"> + {{msg-vector-toc-collapsible-button-label}} {{/data-toc}} {{{html-title-heading}}} diff --git a/skin.json b/skin.json index 6378f17b..ddc72c9a 100644 --- a/skin.json +++ b/skin.json @@ -63,6 +63,8 @@ "vector-jumptocontent", "vector-toc-beginning", "vector-toc-heading", + "vector-toc-menu-tooltip", + "vector-toc-collapsible-button-label", "vector-article-tools-nav-label", "vector-site-nav-label", "search",