jonny
/
Vector-Local
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop skin override 

This is often used by gadgets/scripts to request
information from the API. Given `vector` means old Vector
now that leads to styling issues.

The unfortunate side effect of this is that any code
checking mw.config('skin') === 'vector' will no longer work
and we'll likely need to patch various gadgets accordingly.

Bug: T300814
Change-Id: Ic920e91960cf81790096395256b75f8ed0dc4173
This commit is contained in:
Jon Robson 2022-02-03 08:37:05 -08:00
parent 0bd8ffdd6d
commit 269da58dc3
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
includes/Hooks.php
View File

@ -723,25 +723,6 @@ class Hooks {
Constants::CONFIG_KEY_DISABLE_SIDEBAR_PERSISTENCE
);
}
// [[phab:T297758]] ensure old Vector is the same as new Vector
// from a user script / gadget point of view.
if ( self::isSkinVersionLegacy( $skinName ) ) {
$vars[ 'skin' ] = 'vector';
}
}
/**
* @param array &$vars Array of variables to be added into the output.
* @param string $skin
* @param Config $config
*/
public static function onResourceLoaderGetConfigVars( array &$vars, string $skin, Config $config ) {
// [[phab:T297758]] ensure old Vector is the same as new Vector
// from a user script / gadget point of view.
if ( self::isVectorSkin( $skin ) ) {
$vars['skin'] = 'vector';
}
}
/**

1
skin.json
View File

@ -115,7 +115,6 @@
"vector": "GlobalVarConfig::newInstance"
},
"Hooks": {
"ResourceLoaderGetConfigVars": "Vector\\Hooks::onResourceLoaderGetConfigVars",
"ResourceLoaderSiteModulePages": "Vector\\Hooks::onResourceLoaderSiteModulePages",
"ResourceLoaderSiteStylesModulePages": "Vector\\Hooks::onResourceLoaderSiteStylesModulePages",
"SkinPageReadyConfig": "Vector\\Hooks::onSkinPageReadyConfig",