Layout: Title should always be above tabs

**UI CHANGES**
- This change will result in expected UI changes so will flag problems
with Pixel.
- Before merging please confirm Pixel reports 31 passed, 47 failed
- After merging, we should update LocalSettings.php to reset these
changes.

Bug: T310054
Change-Id: Ib35c6bfa5493f7dc81b63c42e7fedb8f1e47226b

includes/Constants.php

@@ -231,21 +231,6 @@ final class Constants {
 	 */
 	public const WEB_AB_TEST_ARTICLE_ID_FACTORY_SERVICE = 'WikimediaEvents.WebABTestArticleIdFactory';
 
-	/**
-	 * @var string
-	 */
-	public const REQUIREMENT_TITLE_ABOVE_TABS = 'TitleAboveTabs';
-
-	/**
-	 * @var string
-	 */
-	public const CONFIG_TITLE_ABOVE_TABS = 'VectorTitleAboveTabs';
-
-	/**
-	 * @var string
-	 */
-	public const FEATURE_TITLE_ABOVE_TABS = 'TitleAboveTabs';
-
 	/**
 	 * @var string
 	 */

includes/ServiceWiring.php

@@ -209,27 +209,6 @@ return [
 			]
 		);
 
-		// Feature: Title above tabs
-		// ================================
-		$featureManager->registerRequirement(
-			new OverridableConfigRequirement(
-				$services->getMainConfig(),
-				$context->getUser(),
-				$context->getRequest(),
-				null,
-				Constants::CONFIG_TITLE_ABOVE_TABS,
-				Constants::REQUIREMENT_TITLE_ABOVE_TABS
-			)
-		);
-
-		$featureManager->registerFeature(
-			Constants::FEATURE_TITLE_ABOVE_TABS,
-			[
-				Constants::REQUIREMENT_FULLY_INITIALISED,
-				Constants::REQUIREMENT_TITLE_ABOVE_TABS,
-			]
-		);
-
 		// Feature: Grid
 		// ================================
 		$featureManager->registerRequirement(
@@ -250,7 +229,6 @@ return [
 			Constants::FEATURE_GRID,
 			[
 				Constants::REQUIREMENT_FULLY_INITIALISED,
-				Constants::REQUIREMENT_TITLE_ABOVE_TABS,
 				Constants::REQUIREMENT_GRID,
 				Constants::REQUIREMENT_TABLE_OF_CONTENTS,
 			]

includes/SkinVector22.php

@@ -172,7 +172,6 @@ class SkinVector22 extends SkinVector {
 					Constants::FEATURE_STICKY_HEADER_EDIT
 				)
 			) : false,
-			'is-title-above-tabs' => $featureManager->isFeatureEnabled( Constants::FEATURE_TITLE_ABOVE_TABS )
 		];
 	}
 }

includes/templates/skin.mustache

@@ -48,9 +48,6 @@
 	<input type="checkbox" id="vector-toc-collapsed-checkbox" class="mw-checkbox-hack-checkbox">
 	{{/is-vector-grid}}{{/data-toc}}
 	<div id="mw-navigation">
-		{{^is-title-above-tabs}}
-			{{>ArticleToolbar}}
-		{{/is-title-above-tabs}}
 		{{#data-portlets-sidebar}}{{>Sidebar}}{{/data-portlets-sidebar}}
 	</div>
 	{{^is-vector-grid}}
@@ -67,10 +64,7 @@
 	<div id="siteNotice">{{{html-site-notice}}}</div>
 
 	{{>ContentHeader}}
-
-	{{#is-title-above-tabs}}
-		{{>ArticleToolbar}}
-	{{/is-title-above-tabs}}
+	{{>ArticleToolbar}}
 
 	<div id="bodyContent" class="vector-body" {{#is-title-above-tabs}} data-mw-ve-target-container {{/is-title-above-tabs}}>
 		{{>ContentSubheader}}

skin.json

@@ -521,10 +521,6 @@
 		"VectorGrid": {
 			"value": false,
 			"description": "@var boolean `VectorGrid` enforces a grid system"
-		},
-		"VectorTitleAboveTabs": {
-			"value": false,
-			"description": "@var boolean `VectorTitleAboveTabs` places the title of the page above the tabs that link to history/talk etc."
 		}
 	},
 	"ServiceWiringFiles": [