From 55b52831486ed8a84b36445f8333d490331c24d8 Mon Sep 17 00:00:00 2001 From: Jdlrobson Date: Wed, 18 May 2022 15:12:59 +0000 Subject: [PATCH] Revert "Move a max-width Less variable up into variables.less" This reverts commit bf4d843d97c8b5f9ae7d58de892658ef80860ea5. Reason for revert: These variables were intended as local to layout. Only layout stylesheet should have access to layout variables. The risk of having this in the global variables file is that non-layout rules can be added to components. Change-Id: I91fd01ed5333555052c243e25d37cd30d6d9bef6 --- resources/common/variables.less | 1 - resources/skins.vector.styles/layouts/screen.less | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/common/variables.less b/resources/common/variables.less index c8c1af2b..551e0808 100644 --- a/resources/common/variables.less +++ b/resources/common/variables.less @@ -175,6 +175,5 @@ // Layout // @max-width-page-container: unit( 1514px / @font-size-browser, em ); // 99.75em @ 16 -@max-width-content-container: unit( 960px / @font-size-browser, em ); // 60em @ 16 @padding-horizontal-page-container: unit( 32px / @font-size-browser, em ); @padding-horizontal-page-container-wide: unit( 40px / @font-size-browser, em ); diff --git a/resources/skins.vector.styles/layouts/screen.less b/resources/skins.vector.styles/layouts/screen.less index 73da9a8c..3f43a2c8 100644 --- a/resources/skins.vector.styles/layouts/screen.less +++ b/resources/skins.vector.styles/layouts/screen.less @@ -27,9 +27,10 @@ @min-width-page-container--padded: @max-width-page-container + ( 2 * @padding-horizontal-page-container ); // 106.875em -// Content container +// Content containers @max-width-workspace-container: unit( 1514px / @font-size-browser, em ); // 99.75em @ 16 +@max-width-content-container: unit( 960px / @font-size-browser, em ); // 60em @ 16 // Note this uses variables defined in mediawiki.skin.variables so that VisualEditor can read them // see T259331.