From 62e84e7467c1765986cd1f80b466b8cacc6d91f6 Mon Sep 17 00:00:00 2001 From: Clare Ming Date: Mon, 13 Dec 2021 17:31:17 -0700 Subject: [PATCH] Prevent A/B test enrollment hook from firing for unsampled Bug: T297662 Change-Id: Ibeca32a3c0fab7de403d69ea274c653cf4bd6c0e (cherry picked from commit 60553ff324c4e94f1e6ee15150543b9d6bbf6646) --- resources/skins.vector.es6/AB.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/skins.vector.es6/AB.js b/resources/skins.vector.es6/AB.js index 92e2eb31..a108965e 100644 --- a/resources/skins.vector.es6/AB.js +++ b/resources/skins.vector.es6/AB.js @@ -101,7 +101,7 @@ function isInTestGroup( bucket, targetGroup ) { function initAB( bucket ) { // Send data to WikimediaEvents to log A/B test initialization if experiment is enabled // and if the user is logged in. - if ( ABTestConfig.enabled && !mw.user.isAnon() ) { + if ( ABTestConfig.enabled && !mw.user.isAnon() && bucket !== 'unsampled' ) { // @ts-ignore mw.hook( 'mediawiki.web_AB_test_enrollment' ).fire( getABTestGroupExperimentName() );