jonny
/
Vector-Local
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace h2 in TOC with p and remove aria-hidden 

Ideally the TOC has an h2 after the article title h1, but because of the TOC sticky positioning and its placement in the grid, we cant use an h2 without messing up the heading order.

Bug: T301051
Change-Id: I462ddfb618ddd422c9f71293280d1790c4846f50
This commit is contained in:
bwang 2022-04-19 11:54:46 -05:00 committed by Bernard Wang
parent b2c1625d48
commit 9473758efd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
includes/templates/TableOfContents.mustache
View File

@ -1,6 +1,6 @@
<nav id="mw-panel-toc" class="sidebar-toc" role="navigation" aria-labelledby="sidebar-toc-label" data-event-name="ui.sidebar-toc">
<div id="sidebar-toc-label" class="sidebar-toc-header">
<h2 class="sidebar-toc-title" aria-hidden="true">{{ msg-vector-toc-heading }}</h2>
<p class="sidebar-toc-title">{{ msg-vector-toc-heading }}</p>
</div>
<ul class="sidebar-toc-contents">
{{#is-vector-toc-beginning-enabled}}

4
tests/jest/__snapshots__/tableOfContents.test.js.snap
View File

@ -3,7 +3,7 @@
exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\` is false 1`] = `
"<nav id=\\"mw-panel-toc\\" class=\\"sidebar-toc\\" role=\\"navigation\\" aria-labelledby=\\"sidebar-toc-label\\" data-event-name=\\"ui.sidebar-toc\\">
<div id=\\"sidebar-toc-label\\" class=\\"sidebar-toc-header\\">
<h2 class=\\"sidebar-toc-title\\" aria-hidden=\\"true\\">Contents</h2>
<p class=\\"sidebar-toc-title\\">Contents</p>
</div>
<ul class=\\"sidebar-toc-contents\\">
<li id=\\"toc-mw-content-text\\" class=\\"sidebar-toc-list-item sidebar-toc-level-1\\">
@ -62,7 +62,7 @@ exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\`
exports[`Table of contents renders when \`vector-is-collapse-sections-enabled\` is true 1`] = `
"<nav id=\\"mw-panel-toc\\" class=\\"sidebar-toc\\" role=\\"navigation\\" aria-labelledby=\\"sidebar-toc-label\\" data-event-name=\\"ui.sidebar-toc\\">
<div id=\\"sidebar-toc-label\\" class=\\"sidebar-toc-header\\">
<h2 class=\\"sidebar-toc-title\\" aria-hidden=\\"true\\">Contents</h2>
<p class=\\"sidebar-toc-title\\">Contents</p>
</div>
<ul class=\\"sidebar-toc-contents\\">
<li id=\\"toc-mw-content-text\\" class=\\"sidebar-toc-list-item sidebar-toc-level-1\\">