jonny
/
Vector-Local
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "[Refactor] Generalize checkbox hack code"

This commit is contained in:
jenkins-bot 2022-06-10 21:39:05 +00:00 committed by Gerrit Code Review
parent 677684d839 10810ec1da
commit 98cffb3f19
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
resources/skins.vector.js/checkbox.js
View File

@ -4,6 +4,9 @@
* The checkbox hack in Vector provides basic show/hide functionality with CSS
* but JavaScript is used for progressive enhancements.
*
* This code targets any element with a mw-checkbox-hack-button class. It must have
* a for attribute to qualify for enhancements.
*
* Enhancements include:
* - Update `aria-role`s based on expanded/collapsed state.
* - Update button icon based on expanded/collapsed state.
@ -13,9 +16,7 @@
/** @interface MwApiConstructor */
/** @interface CheckboxHack */
var checkboxHack = /** @type {CheckboxHack} */ require( /** @type {string} */( 'mediawiki.page.ready' ) ).checkboxHack,
SIDEBAR_BUTTON_ID = 'mw-sidebar-button',
SIDEBAR_CHECKBOX_ID = 'mw-sidebar-checkbox';
var checkboxHack = /** @type {CheckboxHack} */ require( /** @type {string} */( 'mediawiki.page.ready' ) ).checkboxHack;
/**
* Revise the button's `aria-expanded` state to match the checked state.
@ -117,10 +118,17 @@ function initCheckboxHack( checkbox, button ) {
* @param {Window} window
*/
function init( window ) {
var checkbox = window.document.getElementById( SIDEBAR_CHECKBOX_ID ),
button = window.document.getElementById( SIDEBAR_BUTTON_ID );
var buttons = window.document.querySelectorAll( '.mw-checkbox-hack-button' );
Array.prototype.forEach.call( buttons, function ( button ) {
var checkboxId = button.getAttribute( 'for' ),
checkbox = checkboxId ? window.document.getElementById( checkboxId ) : null;
if ( checkbox ) {
initCheckboxHack( checkbox, button );
}
} );
initCheckboxHack( checkbox, button );
}
module.exports = {