diff --git a/includes/SkinVector.php b/includes/SkinVector.php index a633be1f..6cac3fe3 100644 --- a/includes/SkinVector.php +++ b/includes/SkinVector.php @@ -460,11 +460,8 @@ abstract class SkinVector extends SkinMustache { // Conditionally used values must use null to indicate absence (not false or ''). $commonSkinData = array_merge( $parentData, [ 'is-legacy' => $this->isLegacy(), - 'input-location' => $this->getSearchBoxInputLocation(), - 'sidebar-visible' => $this->isSidebarVisible(), - 'is-language-in-content' => $this->isLanguagesInContent(), 'is-language-in-content-top' => $this->isLanguagesInContentAt( 'top' ), 'is-language-in-content-bottom' => $this->isLanguagesInContentAt( 'bottom' ), diff --git a/includes/SkinVector22.php b/includes/SkinVector22.php index 75e4c7e2..1fbc9ff5 100644 --- a/includes/SkinVector22.php +++ b/includes/SkinVector22.php @@ -167,7 +167,9 @@ class SkinVector22 extends SkinVector { $isGrid = $featureManager->isFeatureEnabled( Constants::FEATURE_GRID ); - return $parentData + [ + return array_merge( $parentData, [ + // Cast empty string to null + 'html-subtitle' => $parentData['html-subtitle'] === '' ? null : $parentData['html-subtitle'], 'is-vector-grid' => $isGrid, 'vector-layout-class' => $isGrid ? 'vector-layout-grid vector-toc-visible' : 'vector-layout-legacy', 'data-vector-sticky-header' => $featureManager->isFeatureEnabled( @@ -185,6 +187,6 @@ class SkinVector22 extends SkinVector { Constants::FEATURE_STICKY_HEADER_EDIT ) ) : false, - ]; + ] ); } } diff --git a/includes/templates/ContentSubheader.mustache b/includes/templates/ContentSubheader.mustache index 18fa5e34..5d40bcfa 100644 --- a/includes/templates/ContentSubheader.mustache +++ b/includes/templates/ContentSubheader.mustache @@ -9,4 +9,4 @@ {{/is-language-in-content-top}} {{#is-article}}
{{/is-article}} - \ No newline at end of file + diff --git a/includes/templates/skin.mustache b/includes/templates/skin.mustache index 22fe72ef..1ff18afd 100644 --- a/includes/templates/skin.mustache +++ b/includes/templates/skin.mustache @@ -68,8 +68,8 @@