From c2e9a7b36610cfff4ae112330655e5fbd0e3f8f2 Mon Sep 17 00:00:00 2001
From: AronDemian <AronManning5@gmail.com>
Date: Fri, 24 Apr 2020 00:16:28 +0200
Subject: [PATCH] Add `.mw-footer` CSS class & replace `#footer` selector with
 it

Does not add `.mw-footer-*` CSS classes to `ul#footer-*` and
`li#footer-*-*` to save bandwidth.

NOTE:
- The former id selectors can be removed form the styles after the varnish cache
  is updated with the new DOM.
- The modern version still uses the legacy layout at this stage.

Bug: T248137
Change-Id: Ica9f8c43617c624648fa12dc86ebb3daa10f0409
---
 includes/templates/Footer.mustache               | 2 +-
 resources/skins.vector.styles.responsive.less    | 3 ++-
 resources/skins.vector.styles/Footer.less        | 3 ++-
 resources/skins.vector.styles/legacy/layout.less | 9 ++++++---
 resources/skins.vector.styles/print.less         | 6 ++++--
 5 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/includes/templates/Footer.mustache b/includes/templates/Footer.mustache
index ba15a17e..de7d951a 100644
--- a/includes/templates/Footer.mustache
+++ b/includes/templates/Footer.mustache
@@ -14,7 +14,7 @@
 	footerRow[] array-footer-rows iterable list of footer rows
 }}
 {{{html-hook-vector-before-footer}}}
-<div id="footer" role="contentinfo" {{{html-userlangattributes}}}>
+<div id="footer" class="mw-footer" role="contentinfo" {{{html-userlangattributes}}}>
 	{{#array-footer-rows}}
 	<ul id="{{id}}" class="{{className}}">
 		{{#array-items}}
diff --git a/resources/skins.vector.styles.responsive.less b/resources/skins.vector.styles.responsive.less
index 1926c18f..20cf8e85 100644
--- a/resources/skins.vector.styles.responsive.less
+++ b/resources/skins.vector.styles.responsive.less
@@ -38,7 +38,8 @@
 	}
 
 	/* Rearrange various page elements to fill the now-available space */
-	body #footer {
+	body #footer,  /* FIXME: Remove 2 weeks after deployment. */
+	body .mw-footer {
 		margin-left: 0;
 		padding-top: 0;
 
diff --git a/resources/skins.vector.styles/Footer.less b/resources/skins.vector.styles/Footer.less
index f48c0bdb..75165e23 100644
--- a/resources/skins.vector.styles/Footer.less
+++ b/resources/skins.vector.styles/Footer.less
@@ -1,7 +1,8 @@
 @import '../../variables.less';
 
 /* Footer */
-#footer {
+#footer, /* FIXME: Remove 2 weeks after deployment. */
+.mw-footer {
 	padding: 0.75em;
 	direction: ltr;
 
diff --git a/resources/skins.vector.styles/legacy/layout.less b/resources/skins.vector.styles/legacy/layout.less
index 68e3747f..76766cba 100644
--- a/resources/skins.vector.styles/legacy/layout.less
+++ b/resources/skins.vector.styles/legacy/layout.less
@@ -68,7 +68,8 @@
 		left: 0;
 	}
 
-	#footer {
+	#footer, /* FIXME: Remove 2 weeks after deployment. */
+	.mw-footer {
 		margin-left: 10em;
 		margin-top: 0;
 	}
@@ -81,7 +82,8 @@
 	#mw-head-base,
 	#left-navigation,
 	#mw-data-after-content,
-	#footer {
+	#footer, /* FIXME: Remove 2 weeks after deployment. */
+	.mw-footer {
 		margin-left: 11em;
 	}
 
@@ -89,7 +91,8 @@
 		padding: 1.25em 1.5em 1.5em 1.5em;
 	}
 
-	#footer {
+	#footer, /* FIXME: Remove 2 weeks after deployment. */
+	.mw-footer {
 		padding: 1.25em;
 	}
 
diff --git a/resources/skins.vector.styles/print.less b/resources/skins.vector.styles/print.less
index dec50552..46de8190 100644
--- a/resources/skins.vector.styles/print.less
+++ b/resources/skins.vector.styles/print.less
@@ -18,7 +18,8 @@
 	// Tables, thumbs and lists are sans-serif in print mode (unlike screen mode) because these will render
 	// more legibly on print media in a smaller font sizes
 	.printfooter,
-	#footer,
+	#footer, /* FIXME: Remove 2 weeks after deployment. */
+	.mw-footer,
 	.thumb,
 	table,
 	ol,
@@ -190,7 +191,8 @@
 		clear: both;
 	}
 
-	#footer {
+	#footer, /* FIXME: Remove 2 weeks after deployment. */
+	.mw-footer {
 		margin-top: 12px;
 		border-top: 1px solid @border-color-footer;
 		padding-top: 5px;