From ce97818dd26fcfe3d37fed1ee5dd6814d2c6f432 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 15 Jan 2018 22:25:34 +0100 Subject: [PATCH] OOUI: Remove confusing 'position' override Vector is the only skin that does this, setting 'position: relative' for .oo-ui-windowManager-modal (normally 'position: static') and for .ve-ui-overlay-global (normally 'position: absolute'). The override for .oo-ui-windowManager-modal caused it to create a new stacking context, which is the only reason the 'z-index' override worked. Use the right selector to override 'z-index' instead. The override for .ve-ui-overlay-global was completely pointless and it's surprising that it never broke anything. Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a --- skinStyles/ooui.less | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/skinStyles/ooui.less b/skinStyles/ooui.less index 12123b27..fa03233e 100644 --- a/skinStyles/ooui.less +++ b/skinStyles/ooui.less @@ -1,9 +1,8 @@ @import '../variables.less'; -.oo-ui-windowManager-modal, +.skin-vector .oo-ui-windowManager-modal > .oo-ui-dialog, .skin-vector .ve-ui-overlay-global { z-index: 101; - position: relative; } .oo-ui-defaultOverlay {