From fc2a899b4daf0084f7f1c744efbd21727344126a Mon Sep 17 00:00:00 2001
From: Jon Robson <jdlrobson@gmail.com>
Date: Mon, 22 Aug 2022 12:32:19 +0100
Subject: [PATCH] Remove FIXME, add variables

These overrides are now redundant now that Vector and Vector 2022
are separate skins.

This override was technical debt, but is now causing inconsistency
in styles as a result of T315321

These are now defined in the variables file instead.

Bug: T315662
Change-Id: I7cb3e7f439daa9d1974ec414ee4c8a905b5e513f
---
 .../mediawiki.skin.variables.less               |  2 ++
 .../skins.vector.styles.legacy/skin-legacy.less | 17 -----------------
 2 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/resources/mediawiki.less.legacy/mediawiki.skin.variables.less b/resources/mediawiki.less.legacy/mediawiki.skin.variables.less
index 30b50aab..715f9577 100644
--- a/resources/mediawiki.less.legacy/mediawiki.skin.variables.less
+++ b/resources/mediawiki.less.legacy/mediawiki.skin.variables.less
@@ -9,3 +9,5 @@
 // Set pre July 2022 colors for links (T213778).
 @color-link: #0645ad;
 @color-link--visited: #0b0080;
+@color-link-new: #ba0000;
+@color-link-new--visited: #a55858;
diff --git a/resources/skins.vector.styles.legacy/skin-legacy.less b/resources/skins.vector.styles.legacy/skin-legacy.less
index a5de62bf..ae298f24 100644
--- a/resources/skins.vector.styles.legacy/skin-legacy.less
+++ b/resources/skins.vector.styles.legacy/skin-legacy.less
@@ -15,23 +15,6 @@
 	@import './components/Sidebar.less';
 	@import './components/TabWatchstarLink.less';
 	@import './components/UserLinks.less';
-
-	// Overrides
-	// Since these override declarations in ResourceLoaderSkinModule they require
-	// the `skin-vector-legacy` class for greater specificity. See T288739.
-	// FIXME: This can be considered for removal in future or can be repurposed as a skin
-	// variable when modern and legacy Vector use different skin keys.
-	.skin-vector-legacy {
-		a.new {
-			color: #ba0000;
-		}
-
-		a.new:visited,
-		.vector-menu-tabs .new a,
-		.vector-menu-tabs .new a:visited {
-			color: #a55858;
-		}
-	}
 }
 
 @media print {