Version of vector used on wiki.jon-e.net
Go to file
Timo Tijhof d56792addb Fix <h1> to be present even if title is "0"
Regression from 74b9803d9a, caused by a bug in LightNCandy which
caused {{foo}} to render "0", and {{#foo}} to pass as true with "0", but then
in {{#foo}}<b>{{foo}}</b>{{/foo} render as empty string producing "<b></b>".
In other words, the conditional is passing and the inner block is executed,
but the placeholder is mistakenly converting "0" => null => "" (empty string),
causing the <h1> to render but without any text in it.

Work around this bug by simply removing the conditional. Several other skins
already don't have this conditional and it's unclear why or in what
situation MediaWiki would send OutputPage to SkinTemplate without a title.

I think it would make sense in such rare case to still have a consistent
layout for extensions and gadgets to interact with and not omit the H1
element, but render it with the value that OutputPage gave it, even if it
is the empty string.

Bug: T219864
Change-Id: I6e04b512d2fe2e949ff5385cb38ceebe392fb255
2019-04-02 19:47:38 +01:00
.phan Upgrade to newer phan 2019-03-20 19:37:59 -07:00
components Merge "Use opacity for a WikimediaUI aligned transition on opening menu" 2019-01-10 07:04:38 +00:00
i18n Localisation updates from https://translatewiki.net. 2019-03-31 22:00:07 +02:00
images Remove obsolete Special:Preferences styles after its transformation to OOUI 2018-11-07 12:50:57 -08:00
includes Fix <h1> to be present even if title is "0" 2019-04-02 19:47:38 +01:00
screenshots Add skin screenshot for the installer 2017-08-11 15:37:34 -04:00
skinStyles Merge "Match frame and overlay appearance of ui-dialog to match WMUI" 2019-04-01 19:39:47 +00:00
.eslintrc.json build: Set "root": true, in .eslintrc.json 2018-12-17 19:02:54 -08:00
.gitignore Merge "Upgrade to newer phan" 2019-03-21 06:55:46 +00:00
.gitreview Use track=1 instead of defaultbranch=master in .gitreview 2016-10-24 17:30:32 -07:00
.phpcs.xml Add method scope visibility 2018-11-01 21:01:32 +01:00
.stylelintrc.json build: Bump devDependencies to latest 2018-02-26 10:29:23 -08:00
CODE_OF_CONDUCT.md build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 2018-09-04 01:45:34 +00:00
collapsibleTabs.js build: Update eslint-config-wikimedia to 0.11.0 2019-03-13 23:23:14 +00:00
composer.json Upgrade to newer phan 2019-03-20 19:37:59 -07:00
COPYING Use the plain-text GPL and fix 'license-name' to match SPDX conventions 2015-01-29 17:04:29 +01:00
Gruntfile.js build: Update eslint-config-wikimedia to 0.11.0 2019-03-13 23:23:14 +00:00
hooks.txt Remove 'SkinVectorStyleModules' hook 2018-01-26 10:33:47 -08:00
jsduck.json collapsibleTabs: Clean up and simplify code 2016-11-29 02:25:00 +00:00
package.json build: Update eslint-config-wikimedia to 0.11.0 2019-03-13 23:23:14 +00:00
print.less build: Update 'stylelint-config-wikimedia' and make pass 2018-12-02 14:40:28 -08:00
README.md Print logo should use an absolute URI 2017-10-11 19:06:29 +00:00
responsive.less build: Update 'stylelint-config-wikimedia' and make pass 2018-12-02 14:40:28 -08:00
screen-hd.less Restructure 'screen-hd' CSS rules 2018-10-13 12:02:06 -07:00
screen.less build: Introduce stylelint and make pass 2016-11-29 08:40:03 -08:00
skin.json Remove jquery.ui.spinner skin styles 2019-03-28 19:19:41 +00:00
variables.less Bring personal tools' icons on baseline with label 2018-10-15 19:02:18 -07:00
vector.js build: Update eslint-config-wikimedia to 0.11.0 2019-03-13 23:23:14 +00:00

Vector Skin

Configuration options

Logo used in print styles. Keys are url, width, and height (in pixels). Note that this solution only works correctly if the image pointed to by url is an SVG that does not specify width and height attributes, or its width and height match the corresponding variables below. Alternatively, a PNG or other type of image can be used, but its dimensions also need to match the corresponding variable below. That in turn may result in blurry images, though.

The URL can be absolute or relative.

Example configuration:

$wgVectorPrintLogo = [
	'url' => 'https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-en.svg',
	'width' => 174,
	'height' => 27
];
  • Type: Array
  • Default: false