mirror of
https://github.com/p2p-ld/nwb-linkml.git
synced 2025-01-09 13:44:27 +00:00
[DATALAD RUNCMD] Do interactive fixing of leftover ambigous typos
=== Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
This commit is contained in:
parent
63a405f4aa
commit
2e2ecf10c0
4 changed files with 4 additions and 4 deletions
|
@ -10,7 +10,7 @@
|
||||||
* Unclear how the schema is used if the containers contain the same information
|
* Unclear how the schema is used if the containers contain the same information
|
||||||
* the [register_container_type](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/build/manager.py#L727-L736) method in hdmf's TypeMap class seems to overwrite the loaded schema???
|
* the [register_container_type](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/build/manager.py#L727-L736) method in hdmf's TypeMap class seems to overwrite the loaded schema???
|
||||||
* `__NS_CATALOG` seems to actually hold references to the schema but it doesn't seem to be used anywhere except within `__TYPE_MAP` ?
|
* `__NS_CATALOG` seems to actually hold references to the schema but it doesn't seem to be used anywhere except within `__TYPE_MAP` ?
|
||||||
* [NWBHDF5IO](https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/src/pynwb/__init__.py#L237-L238) uses `TypeMap` to greate a `BuildManager`
|
* [NWBHDF5IO](https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/src/pynwb/__init__.py#L237-L238) uses `TypeMap` to create a `BuildManager`
|
||||||
* Parent class [HDF5IO](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/backends/hdf5/h5tools.py#L37) then reimplements a lot of basic functionality from elsewhere
|
* Parent class [HDF5IO](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/backends/hdf5/h5tools.py#L37) then reimplements a lot of basic functionality from elsewhere
|
||||||
* Parent-parent metaclass [HDMFIO](https://github.com/hdmf-dev/hdmf/blob/dev/src/hdmf/backends/io.py) appears to be the final writing class?
|
* Parent-parent metaclass [HDMFIO](https://github.com/hdmf-dev/hdmf/blob/dev/src/hdmf/backends/io.py) appears to be the final writing class?
|
||||||
* `BuildManager.build` then [calls `TypeMap.build`](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/build/manager.py#L171) ???
|
* `BuildManager.build` then [calls `TypeMap.build`](https://github.com/hdmf-dev/hdmf/blob/dd39b3878523c4b03f5286fc740752befd192d8b/src/hdmf/build/manager.py#L171) ???
|
||||||
|
|
|
@ -1,6 +1,6 @@
|
||||||
# TODO
|
# TODO
|
||||||
|
|
||||||
Stuff to keep track of that might have been manually overrided that needs to be fixed pre-release
|
Stuff to keep track of that might have been manually overridden that needs to be fixed pre-release
|
||||||
|
|
||||||
- Coerce all listlike things into lists if they are passed as single elements!
|
- Coerce all listlike things into lists if they are passed as single elements!
|
||||||
- Use [fsspec](https://filesystem-spec.readthedocs.io/en/latest/index.html) to interface with DANDI!
|
- Use [fsspec](https://filesystem-spec.readthedocs.io/en/latest/index.html) to interface with DANDI!
|
|
@ -460,7 +460,7 @@ class NWBPydanticGenerator(PydanticGenerator):
|
||||||
if all([s.required for s in cls.attributes.values()]): # pragma: no cover
|
if all([s.required for s in cls.attributes.values()]): # pragma: no cover
|
||||||
return self._make_npytyping_range(cls.attributes)
|
return self._make_npytyping_range(cls.attributes)
|
||||||
# otherwise we need to make permutations
|
# otherwise we need to make permutations
|
||||||
# but not all permutations, because we typically just want to be able to exlude the last possible dimensions
|
# but not all permutations, because we typically just want to be able to exclude the last possible dimensions
|
||||||
# the array classes should always be well-defined where the optional dimensions are at the end, so
|
# the array classes should always be well-defined where the optional dimensions are at the end, so
|
||||||
requireds = {k:v for k,v in cls.attributes.items() if v.required}
|
requireds = {k:v for k,v in cls.attributes.items() if v.required}
|
||||||
optionals = [(k,v) for k, v in cls.attributes.items() if not v.required]
|
optionals = [(k,v) for k, v in cls.attributes.items() if not v.required]
|
||||||
|
|
|
@ -123,7 +123,7 @@ class HDF5Map(Map):
|
||||||
priority: int = 0
|
priority: int = 0
|
||||||
"""
|
"""
|
||||||
Within a phase, sort mapping operations from low to high priority
|
Within a phase, sort mapping operations from low to high priority
|
||||||
(maybe this should be renamed because highest priority last doesnt make a lot of sense)
|
(maybe this should be renamed because highest priority last doesn't make a lot of sense)
|
||||||
"""
|
"""
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
|
|
Loading…
Reference in a new issue