p2p-ld/nwb-linkml
1
0
Fork 0
mirror of https://github.com/p2p-ld/nwb-linkml.git synced 2024-09-20 16:04:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove commented out pdb call, add more inline docs to rolldown

Browse source
This commit is contained in:
sneakers-the-rat 2024-09-19 19:28:17 -07:00
parent e06c8ad656
commit 734088f18e
Signed by untrusted user who does not match committer: jonny
GPG key ID: 6DCB96EF1E4D232D
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
nwb_linkml/src/nwb_linkml/adapters/namespaces.py
View file

@ -178,6 +178,11 @@ class NamespacesAdapter(Adapter):
nwb-schema-language inheritance doesn't work like normal python inheritance - nwb-schema-language inheritance doesn't work like normal python inheritance -
instead of inheriting everything at the 'top level' of a class, it also instead of inheriting everything at the 'top level' of a class, it also
recursively merges all properties from the parent objects. recursively merges all properties from the parent objects.
While this operation does not take care to modify classes in a way that respect their order
(i.e. roll down ancestor classes first, in order, before the leaf classes),
it doesn't matter - this method should be both idempotent and order insensitive
for a given source schema.
References: References:
https://github.com/NeurodataWithoutBorders/pynwb/issues/1954 https://github.com/NeurodataWithoutBorders/pynwb/issues/1954
@ -191,11 +196,9 @@ class NamespacesAdapter(Adapter):
# merge and cast # merge and cast
new_cls: dict = {} new_cls: dict = {}
for i, parent in enumerate(parents): for i, parent in enumerate(parents):
# if parent.neurodata_type_def == "PatchClampSeries": # we want a full roll-down of all the ancestor classes,
# pdb.set_trace() # but we make an abbreviated leaf class
complete = True complete = False if i == len(parents) - 1 else True
if i == len(parents) - 1:
complete = False
new_cls = roll_down_nwb_class(new_cls, parent, complete=complete) new_cls = roll_down_nwb_class(new_cls, parent, complete=complete)
new_cls: Group | Dataset = type(cls)(**new_cls) new_cls: Group | Dataset = type(cls)(**new_cls)
new_cls.parent = cls.parent new_cls.parent = cls.parent