minor todos

This commit is contained in:
sneakers-the-rat 2024-07-09 23:15:29 -07:00
parent b6af8c9718
commit efd05724e3
Signed by untrusted user who does not match committer: jonny
GPG key ID: 6DCB96EF1E4D232D
2 changed files with 16 additions and 2 deletions

4
.gitignore vendored
View file

@ -165,4 +165,6 @@ prof
jupyter_execute jupyter_execute
.pdm-python .pdm-python
.venv* .venv*
requests-cache.sqlite

View file

@ -8,12 +8,24 @@ NWB schema translation
- handle compound `dtype` like in TimeSeriesReferenceVectorData - handle compound `dtype` like in TimeSeriesReferenceVectorData
- Create a validator that checks if all the lists in a compound dtype dataset are same length - Create a validator that checks if all the lists in a compound dtype dataset are same length
Cleanup
- [ ] Update pydantic generator
- [ ] Make a minimal pydanticgen-only package to slim linkml deps?
- [ ] Disambiguate "maps" terminology - split out simple maps from the eg. dataset mapping classes
Important things that are not implemented yet! Important things that are not implemented yet!
- {meth}`nwb_linkml.adapters.classes.ClassAdapter.handle_dtype` does not yet handle compound dtypes, - [x] {meth}`nwb_linkml.adapters.classes.ClassAdapter.handle_dtype` does not yet handle compound dtypes,
leaving them as `AnyType` instead. This is fine for a first draft since they are used rarely within leaving them as `AnyType` instead. This is fine for a first draft since they are used rarely within
NWB, but we will need to handle them by making slots for each of the dtypes since they typically NWB, but we will need to handle them by making slots for each of the dtypes since they typically
represent table-like data. represent table-like data.
- [ ] Need to handle DynamicTables!
- Adding columns?
- Validating eg. all are same length?
- Or do we want to just say "no dynamictables, just subclass and add more slots since it's super easy to do that."
- method to return a dataframe
- append rows/this should just be a df basically.
- [ ] Handle indirect indexing eg. https://pynwb.readthedocs.io/en/stable/tutorials/general/plot_timeintervals.html#accessing-referenced-timeseries
## Docs TODOs ## Docs TODOs