v5.47.0

Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>

.eslintignore

@@ -1,3 +1,4 @@
+build/**
 components/**
 coverage/**
 dist/**
@@ -14,7 +15,6 @@ libtextsecure/components.js
 libtextsecure/test/test.js
 test/test.js
 sticker-creator/dist/**
-ts/protobuf/compiled.d.ts
 
 # Third-party files
 js/Mp3LameEncoder.min.js
@@ -25,6 +25,7 @@ app/**/*.js
 ts/**/*.js
 sticker-creator/**/*.js
 
+**/*.d.ts
 .eslintrc.js
 webpack.config.ts
 preload.bundle.*

.eslintrc.js

@@ -15,14 +15,6 @@ const rules = {
     },
   ],
 
-  // No omitting braces, keep on the same line
-  'brace-style': ['error', '1tbs', { allowSingleLine: false }],
-  curly: ['error', 'all'],
-
-  // Always use === and !== except when directly comparing to null
-  // (which only will equal null or undefined)
-  eqeqeq: ['error', 'always', { null: 'never' }],
-
   // prevents us from accidentally checking in exclusive tests (`.only`):
   'mocha/no-exclusive-tests': 'error',
 
@@ -36,9 +28,6 @@ const rules = {
   // useful for unused or internal fields
   'no-underscore-dangle': 'off',
 
-  // Temp: We have because TypeScript's `allowUnreachableCode` option is on.
-  'no-unreachable': 'error',
-
   // though we have a logger, we still remap console to log to disk
   'no-console': 'error',
 
@@ -120,19 +109,12 @@ const rules = {
         '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
     },
   ],
+  curly: 'error',
 };
 
 const typescriptRules = {
   ...rules,
 
-  // Override brace style to enable typescript-specific syntax
-  'brace-style': 'off',
-  '@typescript-eslint/brace-style': [
-    'error',
-    '1tbs',
-    { allowSingleLine: false },
-  ],
-
   '@typescript-eslint/array-type': ['error', { default: 'generic' }],
 
   'no-restricted-imports': 'off',
@@ -191,7 +173,6 @@ module.exports = {
         'app/**/*.ts',
         'sticker-creator/**/*.ts',
         'sticker-creator/**/*.tsx',
-        'build/intl-linter/**/*.ts',
       ],
       parser: '@typescript-eslint/parser',
       parserOptions: {
@@ -212,12 +193,7 @@ module.exports = {
       rules: typescriptRules,
     },
     {
-      files: [
-        '**/*.stories.tsx',
-        'ts/build/**',
-        'ts/test-*/**',
-        'build/intl-linter/**/*.ts',
-      ],
+      files: ['**/*.stories.tsx', 'ts/build/**', 'ts/test-*/**'],
       rules: {
         ...typescriptRules,
         'import/no-extraneous-dependencies': 'off',

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,7 +14,7 @@ Remember, you can preview this before saving it.
 
 ### Contributor checklist:
 
-- [ ] My contribution is **not** related to translations.
+- [ ] My contribution is **not** related to translations. _Please submit translation changes via our [Signal Desktop Transifex project](https://www.transifex.com/signalapp/signal-desktop/)._
 - [ ] My commits are in nice logical chunks with [good commit messages](http://chris.beams.io/posts/git-commit/)
 - [ ] My changes are [rebased](https://medium.com/free-code-camp/git-rebase-and-the-golden-rule-explained-70715eccc372) on the latest [`main`](https://github.com/signalapp/Signal-Desktop/tree/main) branch
 - [ ] A `yarn ready` run passes successfully ([more about tests here](https://github.com/signalapp/Signal-Desktop/blob/master/CONTRIBUTING.md#tests))

.github/workflows/backport.yml

@@ -1,4 +1,4 @@
-# Copyright 2021-2022 Signal Messenger, LLC
+# Copyright 2021 Signal Messenger, LLC
 # SPDX-License-Identifier: AGPL-3.0-only
 
 name: Backport
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v2
         with:
           token: ${{ secrets.AUTOMATED_GITHUB_PAT }}
           repository: signalapp/Signal-Backport-Action-Private

.github/workflows/benchmark.yml

@@ -23,12 +23,12 @@ jobs:
       run: uname -a
 
     - name: Clone Desktop repo
-      uses: actions/checkout@v3
+      uses: actions/checkout@v2
 
     - name: Setup node.js
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - name: Install global dependencies
       run: npm install -g yarn@1.22.10
 
@@ -37,7 +37,7 @@ jobs:
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -106,13 +106,13 @@ jobs:
 
     - name: Upload benchmark logs on failure
       if: failure()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v2
       with:
         name: logs
         path: artifacts
 
     - name: Clone benchmark repo
-      uses: actions/checkout@v3
+      uses: actions/checkout@v2
       with:
         repository: 'signalapp/Signal-Desktop-Benchmarks-Private'
         path: 'benchmark-results'

.github/workflows/ci.yml

@@ -18,15 +18,15 @@ jobs:
     steps:
     - run: lsb_release -a
     - run: uname -a
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - run: npm install -g yarn@1.22.10
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -42,21 +42,21 @@ jobs:
 
   macos:
     needs: lint
-    runs-on: macos-latest
+    runs-on: macos-11.0
     if: github.ref == 'refs/heads/development' || github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main'
     timeout-minutes: 30
 
     steps:
     - run: uname -a
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - run: npm install -g yarn@1.22.10
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -66,14 +66,14 @@ jobs:
 
     - run: yarn generate
     - run: yarn prepare-beta-build
-    - run: yarn test-node
-    - run: yarn test-electron
-      timeout-minutes: 5
     - run: yarn build
       env:
         DISABLE_INSPECT_FUSE: on
     - name: Rebuild native modules for x64
       run: yarn electron:install-app-deps
+    - run: yarn test-node
+    - run: yarn test-electron
+      timeout-minutes: 5
     - run: yarn test-release
       env:
         NODE_ENV: production
@@ -86,16 +86,16 @@ jobs:
     steps:
     - run: lsb_release -a
     - run: uname -a
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - run: sudo apt-get install xvfb
     - run: npm install -g yarn@1.22.10
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -127,15 +127,15 @@ jobs:
     - run: systeminfo
     - run: git config --global core.autocrlf false
     - run: git config --global core.eol lf
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - run: npm install -g yarn@1.22.10
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -171,12 +171,12 @@ jobs:
       run: uname -a
 
     - name: Clone Desktop repo
-      uses: actions/checkout@v3
+      uses: actions/checkout@v2
 
     - name: Setup node.js
-      uses: actions/setup-node@v3
+      uses: actions/setup-node@v2
       with:
-        node-version: '16.15.0'
+        node-version: '16.13.2'
     - name: Install global dependencies
       run: npm install -g yarn@1.22.10
 
@@ -185,7 +185,7 @@ jobs:
 
     - name: Cache Desktop node_modules
       id: cache-desktop-modules
-      uses: actions/cache@v3
+      uses: actions/cache@v2
       with:
         path: node_modules
         key: ${{ runner.os }}-${{ hashFiles('package.json', 'yarn.lock', 'patches/**') }}
@@ -207,11 +207,3 @@ jobs:
       env:
         NODE_ENV: production
         DEBUG: mock:test:*
-        ARTIFACTS_DIR: artifacts/startup
-
-    - name: Upload mock server test logs on failure
-      if: failure()
-      uses: actions/upload-artifact@v2
-      with:
-        name: logs
-        path: artifacts

.github/workflows/danger.yml

@@ -1,32 +0,0 @@
-# Copyright 2020-2022 Signal Messenger, LLC
-# SPDX-License-Identifier: AGPL-3.0-only
-
-name: CI
-on:
-  pull_request:
-
-jobs:
-  danger:
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0 # fetch all history
-      - uses: actions/setup-node@v3
-        with:
-          node-version: '16.15.0'
-      - run: npm install -g yarn@1.22.10
-      - name: Cache danger node_modules
-        id: cache-desktop-modules
-        uses: actions/cache@v3
-        with:
-          path: danger/node_modules
-          key: danger-${{ runner.os }}-${{ hashFiles('danger/package.json', 'danger/yarn.lock') }}
-      - name: Install danger node_modules
-        if: steps.cache-desktop-modules.outputs.cache-hit != 'true'
-        run: cd danger && yarn install --frozen-lockfile
-      - name: Run DangerJS
-        run: yarn danger:ci
-        env:
-          DANGER_GITHUB_API_TOKEN: ${{ secrets.AUTOMATED_GITHUB_PAT }}

.gitignore

@@ -1,5 +1,4 @@
 node_modules
-node_modules_bkp
 .sass-cache
 coverage/*
 build/curve25519_compiled.js
@@ -17,7 +16,6 @@ release/
 /start.sh
 .eslintcache
 tsconfig.tsbuildinfo
-.smartling-source.sh
 
 # generated files
 js/components.js

.nvmrc

@@ -1 +1 @@
-16.15.0
+16.13.2

.prettierignore

@@ -35,6 +35,12 @@ js/WebAudioRecorderMp3.js
 # Github workflows
 .github/**
 
+# Managed by Transifex:
+# Note: the negate pattern only works because it's targeting the same depth as the
+#   glob on the previous line.
+_locales/**/*.json
+!_locales/en/messages.json
+
 # Managed by package manager (`bower` and `yarn`/`npm`):
 /bower.json
 /package.json

.smartling-source-example.sh

@@ -1,9 +0,0 @@
-#!/bin/bash
-# Copyright 2022 Signal Messenger, LLC
-# SPDX-License-Identifier: AGPL-3.0-only
-
-# run this before yarn get-strings/push-strings:
-#   source .smartling-source.sh
-
-export SMARTLING_USER="your token 'user identifier' here"
-export SMARTLING_SECRET="your token secret here"

.smartling.yml

@@ -1,7 +0,0 @@
-# Copyright 2022 Signal Messenger, LLC
-# SPDX-License-Identifier: AGPL-3.0-only
-
-# https://github.com/Smartling/smartling-cli/wiki/examples.md
-
-account_id: '92ff14ad'
-project_id: 'ef62d1ebb'

.storybook/main.js

@@ -13,11 +13,5 @@ module.exports = {
     '@storybook/addon-measure',
     '@storybook/addon-toolbars',
     '@storybook/addon-viewport',
-
-    // This must be imported last.
-    '@storybook/addon-interactions',
-
-    // Deprecated! Please remove when all uses have been migrated to controls.
-    '@storybook/addon-knobs',
   ],
 };

.storybook/preview-head.html

@@ -9,9 +9,6 @@
   type="text/css"
 />
 <script>
-  // eslint-disable-next-line
-  const noop = () => {};
-
   window.SignalWindow = window.SignalWindow || {};
   window.SignalWindow.log = {
     fatal: console.error.bind(console),
@@ -22,27 +19,19 @@
     trace: console.trace.bind(console),
   };
   window.SignalContext = {
-    activeWindowService: {
-      isActive: () => true,
-      registerForActive: noop,
-      unregisterForActive: noop,
-      registerForChange: noop,
-      unregisterForChange: noop,
-    },
-
     nativeThemeListener: {
       getSystemValue: async () => 'light',
-      subscribe: noop,
-      unsubscribe: noop,
+      subscribe: () => {},
+      unsubscribe: () => {},
     },
     Settings: {
       themeSetting: {
         getValue: async () => 'light',
       },
-      waitForChange: () => new Promise(noop),
+      waitForChange: () => {},
     },
     OS: {
-      hasCustomTitleBar: () => false,
+      isWindows11: () => false,
     },
   };
 </script>

.storybook/preview.tsx

@@ -70,7 +70,7 @@ const withModeAndThemeProvider = (Story, context) => {
 };
 
 const withI18n = (Story, context) => (
-  <I18n messages={messages} locale="en">
+  <I18n messages={messages}>
     <Story {...context} />
   </I18n>
 );

.tx/config

@@ -0,0 +1,9 @@
+[main]
+host = https://www.transifex.com
+
+[o:signalapp:p:signal-desktop:r:messagesjson-electron]
+file_filter = _locales/<lang>/messages.json
+source_file = _locales/en/messages.json
+source_lang = en
+type        = CHROME
+

ACKNOWLEDGMENTS.md

@@ -5,10 +5,6 @@
 
 Signal Desktop makes use of the following open source projects.
 
-## @formatjs/fast-memoize
-
-    License: MIT
-
 ## @indutny/frameless-titlebar
 
     MIT License
@@ -2131,33 +2127,6 @@ Signal Desktop makes use of the following open source projects.
     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
     OTHER DEALINGS IN THE SOFTWARE.
 
-## mp4box
-
-    Copyright (c) 2012. Telecom ParisTech/TSI/MM/GPAC Cyril Concolato
-    All rights reserved.
-
-    Redistribution and use in source and binary forms, with or without
-    modification, are permitted provided that the following conditions are met:
-    * Redistributions of source code must retain the above copyright
-    notice, this list of conditions and the following disclaimer.
-    * Redistributions in binary form must reproduce the above copyright
-    notice, this list of conditions and the following disclaimer in the
-    documentation and/or other materials provided with the distribution.
-    * Neither the name of the copyright holder nor the
-    names of its contributors may be used to endorse or promote products
-    derived from this software without specific prior written permission.
-
-    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-    DISCLAIMED. IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY
-    DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-    (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-    LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
-    ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-    SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
 ## mustache
 
     The MIT License
@@ -2652,6 +2621,10 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
+## pino-multi-stream
+
+    License: MIT
+
 ## protobufjs
 
     This license applies to all parts of protobuf.js except those files
@@ -2863,10 +2836,6 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
-## react-intl
-
-    License: BSD-3-Clause
-
 ## react-measure
 
     The MIT License (MIT)
@@ -2991,29 +2960,6 @@ Signal Desktop makes use of the following open source projects.
     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
     SOFTWARE.
 
-## react-textarea-autosize
-
-    The MIT License (MIT)
-
-    Copyright (c) 2013 Andrey Popp
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy of
-    this software and associated documentation files (the "Software"), to deal in
-    the Software without restriction, including without limitation the rights to
-    use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
-    the Software, and to permit persons to whom the Software is furnished to do so,
-    subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in all
-    copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
-    FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
-    COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
-    IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-    CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
 ## react-virtualized
 
     The MIT License (MIT)
@@ -3182,6 +3128,30 @@ Signal Desktop makes use of the following open source projects.
     ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
     IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
+## rotating-file-stream
+
+    The MIT License (MIT)
+
+    Copyright (c) 2015-2020 Daniele Ricci
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in all
+    copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE.
+
 ## sanitize.css
 
     License: CC0-1.0
@@ -3449,9 +3419,7 @@ Signal Desktop makes use of the following open source projects.
 
 ## typeface-inter
 
-    Copyright (c) 2016-2020 The Inter Project Authors.
-    "Inter" is trademark of Rasmus Andersson.
-    https://github.com/rsms/inter
+    Copyright (c) 2016-2018 The Inter Project Authors (me@rsms.me)
 
     This Font Software is licensed under the SIL Open Font License, Version 1.1.
     This license is copied below, and is also available with a FAQ at:

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-<!-- Copyright 2015-2022 Signal Messenger, LLC -->
+<!-- Copyright 2015-2020 Signal Messenger, LLC -->
 <!-- SPDX-License-Identifier: AGPL-3.0-only -->
 
 # Contributor Guidelines
@@ -191,11 +191,13 @@ So you wanna make a pull request? Please observe the following guidelines.
 
 - First, make sure that your `yarn ready` run passes - it's very similar to what our
   Continuous Integration servers do to test the app.
-- Please do not submit pull requests for translation fixes.
+- Please do not submit pull requests for translation fixes. Anyone can update
+  the translations in [Transifex](https://www.transifex.com/projects/p/signal-desktop).
 - Never use plain strings right in the source code - pull them from `messages.json`!
   You **only** need to modify the default locale
   [`_locales/en/messages.json`](_locales/en/messages.json). Other locales are generated
-  automatically based on that file and then periodically translated.
+  automatically based on that file and then periodically uploaded to Transifex for
+  translation.
 - [Rebase](https://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/) your
   changes on the latest `main` branch, resolving any conflicts.
   This ensures that your changes will merge cleanly when you open your PR.
@@ -272,3 +274,15 @@ yarn build
 ```
 
 Then, run the tests using `yarn test-release`.
+
+## Translations
+
+To pull the latest translations, follow these steps:
+
+1.  Download Transifex client:
+    https://docs.transifex.com/client/installing-the-client
+2.  Create Transifex account: https://transifex.com
+3.  Generate API token: https://www.transifex.com/user/settings/api/
+4.  Create `~/.transifexrc` configuration:
+    https://docs.transifex.com/client/client-configuration#-transifexrc
+5.  Run `yarn get-strings`.

README.md

@@ -20,6 +20,12 @@ Please search for any [existing issues](https://github.com/signalapp/Signal-Desk
 
 Please use our community forum: https://community.signalusers.org/
 
+## Contributing Translations
+
+Interested in helping to translate Signal? Contribute here:
+
+https://www.transifex.com/projects/p/signal-desktop
+
 ## Contributing Code
 
 Please see [CONTRIBUTING.md](https://github.com/signalapp/Signal-Desktop/blob/main/CONTRIBUTING.md)