jonny/Vector-Local
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add .mw-footer CSS class & replace #footer selector with it

Browse source 
Does not add `.mw-footer-*` CSS classes to `ul#footer-*` and
`li#footer-*-*` to save bandwidth.

NOTE:
- The former id selectors can be removed form the styles after the varnish cache
  is updated with the new DOM.
- The modern version still uses the legacy layout at this stage.

Bug: T248137
Change-Id: Ica9f8c43617c624648fa12dc86ebb3daa10f0409
This commit is contained in:
AronDemian 2020-04-24 00:16:28 +02:00 committed by Volker E
parent c745dc19f9
commit c2e9a7b366
5 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/templates/Footer.mustache
View file

@ -14,7 +14,7 @@
footerRow[] array-footer-rows iterable list of footer rows footerRow[] array-footer-rows iterable list of footer rows
}} }}
{{{html-hook-vector-before-footer}}} {{{html-hook-vector-before-footer}}}
<div id="footer" role="contentinfo" {{{html-userlangattributes}}}> <div id="footer" class="mw-footer" role="contentinfo" {{{html-userlangattributes}}}>
{{#array-footer-rows}} {{#array-footer-rows}}
<ul id="{{id}}" class="{{className}}"> <ul id="{{id}}" class="{{className}}">
{{#array-items}} {{#array-items}}

3
resources/skins.vector.styles.responsive.less
View file

@ -38,7 +38,8 @@
} }
/* Rearrange various page elements to fill the now-available space */ /* Rearrange various page elements to fill the now-available space */
body #footer { body #footer, /* FIXME: Remove 2 weeks after deployment. */
body .mw-footer {
margin-left: 0; margin-left: 0;
padding-top: 0; padding-top: 0;

3
resources/skins.vector.styles/Footer.less
View file

@ -1,7 +1,8 @@
@import '../../variables.less'; @import '../../variables.less';
/* Footer */ /* Footer */
#footer { #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer {
padding: 0.75em; padding: 0.75em;
direction: ltr; direction: ltr;

9
resources/skins.vector.styles/legacy/layout.less
View file

@ -68,7 +68,8 @@
left: 0; left: 0;
} }
#footer { #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer {
margin-left: 10em; margin-left: 10em;
margin-top: 0; margin-top: 0;
} }
@ -81,7 +82,8 @@
#mw-head-base, #mw-head-base,
#left-navigation, #left-navigation,
#mw-data-after-content, #mw-data-after-content,
#footer { #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer {
margin-left: 11em; margin-left: 11em;
} }
@ -89,7 +91,8 @@
padding: 1.25em 1.5em 1.5em 1.5em; padding: 1.25em 1.5em 1.5em 1.5em;
} }
#footer { #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer {
padding: 1.25em; padding: 1.25em;
} }

6
resources/skins.vector.styles/print.less
View file

@ -18,7 +18,8 @@
// Tables, thumbs and lists are sans-serif in print mode (unlike screen mode) because these will render // Tables, thumbs and lists are sans-serif in print mode (unlike screen mode) because these will render
// more legibly on print media in a smaller font sizes // more legibly on print media in a smaller font sizes
.printfooter, .printfooter,
#footer, #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer,
.thumb, .thumb,
table, table,
ol, ol,
@ -190,7 +191,8 @@
clear: both; clear: both;
} }
#footer { #footer, /* FIXME: Remove 2 weeks after deployment. */
.mw-footer {
margin-top: 12px; margin-top: 12px;
border-top: 1px solid @border-color-footer; border-top: 1px solid @border-color-footer;
padding-top: 5px; padding-top: 5px;